[OPEN-575] roweditor: column-drag-drop, resize problems

[jeffcrilly]

http://www.extjs.com/deploy/dev/exam...ow-editor.html

I've been integrating the very nice roweditor ux into an app I'm working on, and in the process of "testing for bulletproofness" noticed some issues with the roweditor ux.

Issue A : data-out-of-sync-when-grid-columns-are-reordered

One major (imo) issue is the reordering of columns while the editor is active.
1) go to the demo page - i.e. the official extjs samples (link is above).
2) double click to start editing a row.
3) drag a column, e.g. put salary in front of name.

Notice that the fields in the editor are not updated.

Reproducibility: This appears to be reproducible on the extjs demo page which (afaict) is running 3.1.1.

[edit] a workaround is to disable column drag/drop. Though this behavior is then inconsistent with other places in the app.

[edit] Ideally, the editor (imo) should "cancel" the changes, even if a cell is dirty.
Alternatively, the editor ~could~ prompt the user, but this seems tedious.
My expectation is the user gave up on editing once the reorder task started.

[edit] attached screenshot from extjs demo page


Issue B - row-editor-controls-do-not-refresh-on-resize

Another issue I noticed is when the editor is used in a "resizeable" window.
On resize the editor buttons are not updated.
I worked around this problem by adding a doing a "refreshFields" on the "resize" event.

Reproducibility: I am currently using 3.0 and have not verified this issue w/ 3.1.1.
However a brief scan of the 3.1.1 roweditor code leads me to believe this is an issue w/ 3.1.1 also.

(apologies if this has been covered. I did a search but nothing relevant seemed to pop up.)

jeff

[raluca]

I'm having the same issue. Any chance of getting these issues fixed in the near future?

[Jamie Avins]

It's an open issue, we'll get to them as soon as we can. Note that UX components are typically considered a lower priority than other components.

[JimmyInMD]

Any updates or workarounds for this?

Thanks!

[raluca]

I just disabled the column move option on the grids that use an ux editor. I didn't really need the column move option anyway. I did not looked for another solution.

[Bdfy]

I just disabled the column move option on the grids that use an ux editor. I didn't really need the column move option anyway. I did not looked for another solution.

In 3.1.1 all OK - I dont use 3.2 because this bug.

[Dipish]

Bdfy, Just checked 3.1.1, same thing. Could figure out what's wrong with that...

[dead_man]

I changed the script and corrected problem with column resize. Tested on Firefox 3.6.3, IE6, Opera 10, Google Chrome 4.1. Please test and inform me.

There is still column movement bug.

[Dipish]

I don't experience column resize problem, this is working fine. But the fields layout crashes on column move (i.e. reordering columns)

[mdmitry]

I've done a little investigation on this bug.

In function initFields there's a line: this.removeAll(false); - remove all editors from RowEditor, and it removes all extraCls = 'x-box-item' from all editors (@ ContainerLayout::onRemove)

So extraCls is attached to editors only once during rendering (ContainerLayout::configureItem), but removed on first detach from container.

So my simple & dirty fix would be

    initFields: function(){
        ...
        for(var i = 0, len = cm.getColumnCount(); i < len; i++){
            ...
            this.insert(i, ed);
            if (typeof(this.layout) == 'object') {
                var wrap = ed.wrap ? ed.wrap : ed;
                wrap.addClass(this.layout.extraCls);
                this.afterRender();
            }
        }
        this.initialized = true;
    },

edit: my bug is actually that after reordering columns a couple of times (or doing grid reconfigure()) editor fields mess up.

roweditbug.png