Results 1 to 8 of 8

Thread: [OPEN-250] Bad RowEditor buttons positioning

    You found a bug! We've classified it as a bug in our system. We encourage you to continue the discussion and to find an acceptable workaround while we work on a permanent fix.
  1. #1
    Ext JS Premium Member
    Join Date
    Mar 2008
    Location
    Moscow
    Posts
    137

    Default [OPEN-250] Bad RowEditor buttons positioning

    Ext version tested:

    • Ext 3.0.1 rev 5350



    Adapter used:

    • ext



    css used:

    • only default ext-all.css



    Browser versions tested against:

    • IE8
    • Opera 9.64
    • FF3.5.3 (firebug 1.5X.0a24 installed)
    • Safari 4.0.3



    Operating System:

    • Windows Server 2008



    Description:

    • When RowEditor shows on the grid for the second time on a row - buttons position on the top line of the RowEditor. This problem doesn't exist on IE only.



    Test Case:

    • Tested this issue on SVN version #5350 on the RowEditor sample (examples/grid/row-editor.html)


    Steps to reproduce the problem:


    • Click grid row to edit (show RowEditor)
    • Press update button on RowEditor
    • As soon as roweditor hides - click on the same row to show RowEditor


    The result that was expected:

    • Buttons must position on the bottom line of the RowEditor



    The result that occurs instead:

    • Buttons position on the top line of RowEditor



    Screenshot or Video:

    • MustBe.jpg - this how it must work
    • Problem.jpg - this how the problem looks like



    Debugging already done:

    • RowEditor.js:Line 359
      Code:
      var h = this.el.dom.clientHeight;
      when opening for the second time - h equals 6, but must be 30.



    Possible fix:

    • Dirty hack : setting h = 30 - fixes the problem.
    Attached Images Attached Images

  2. #2
    Sencha Premium User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,257

    Default

    Confirmed. I've logged a ticket.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

  3. #3
    Sencha Premium User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,257

    Default

    Thanks for the report.

    Fix applied to svn in rev #5365 for patch release 3.0.3.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

  4. #4
    Sencha Premium User powellke's Avatar
    Join Date
    Sep 2008
    Location
    Huntsville, AL
    Posts
    38

    Default

    I just downloaded 3.0.3 and tried the Row Editor Grid sample and the problem still exists. Double-click a row to open the row editor and it is ok. Dismiss the row editor by clicking Update or Cancel. Double-click another row to open the row editor and the buttons are misaligned. I'm using Windows and the problem seems to only exist on Firefox. IE, Chrome, and Safari work as expected.

  5. #5

    Default

    I would like to note that using RowEditor.js from http://www.extjs.com/deploy/dev/exam...x/RowEditor.js, the problem occurred for me in Firefox, Chromium, and Safari on Mac. I then replaced it with http://code.extjs.com/svn/ext/trunk/...x/RowEditor.js and the problem has been fixed in all of those browsers. Thanks.

  6. #6

    Default

    I'm on 3.1.0 and still had this problem.
    Had to set to 28 for proper alignment, hack works. Thx!

  7. #7
    Ext JS Premium Member
    Join Date
    Dec 2009
    Posts
    17

    Default Issue still present in 3.2.1

    I still get this issue in extjs 3.2.1 (public release)
    As reported above, "h = this.el.dom.clientHeight" returns 6
    so I have just applied a hack and am forcing it to 28

    tested in FF3.6.3

    Filip

  8. #8

    Default

    In IE8 this problem still exists. Does anyone have a quick fix for this problem?

    Thanks in advance.

Similar Threads

  1. Buttons Look Bad in Firefox
    By Clever Cutter in forum Ext 3.x: Help & Discussion
    Replies: 4
    Last Post: 20 Aug 2010, 9:15 AM
  2. Replies: 1
    Last Post: 10 Nov 2009, 5:10 AM
  3. Replies: 1
    Last Post: 17 Sep 2009, 2:04 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •