Results 1 to 4 of 4

Thread: [CLOSED][DUP][3.0.0] href="#" with onclick="return false"

    Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1

    Default [CLOSED][DUP][3.0.0] href="#" with onclick="return false"

    Ext version tested:
    • Ext 3.0.0


    Adapter used:
    • ext


    css used:
    • only default ext-all.css


    Browser versions tested against:
    • Firefox 3.5
    • Chrome 3.0.98


    Operating System:
    • Linux


    Description:
    • Why do you set 'href="#"' for a elements with 'onclick="return false"'? That produces a statusbar message, which is not necessary at all. In Chrome it looks especially ugly since the statusbar does just show up if there is a text to display.


    Test Case:
    • Create a TabPanel with a few tabs. When you hover the tabstripes, http://example.com/foo# shows up in the statusbar of the browser.


    Steps to reproduce the problem:
    • see above


    The result that was expected:
    • Do not show any text in the statusbar since it is not useful at all for the user.


    The result that occurs instead:
    • see above


    Debugging already done:
    • I have removed 'href="#"' from the TabPanel template. It seems to work fine in both Chrome and Firefox.


    Possible fix:
    • Change for TabPanel (but do not forget all the other usages of this issue!):
      Code:
                  var tt = new Ext.Template(
                       '<li class="{cls}" id="{id}"><a class="x-tab-strip-close" onclick="return false;"></a>',
                       '<a class="x-tab-right" href="#" onclick="return false;"><em class="x-tab-left">',
                       '<span class="x-tab-strip-inner"><span class="x-tab-strip-text {iconCls}">{text}</span></span>',
                       '</em></a></li>'
                  );
      to:
      Code:
                  var tt = new Ext.Template(
                       '<li class="{cls}" id="{id}"><a class="x-tab-strip-close" onclick="return false;"></a>',
                       '<a class="x-tab-right" onclick="return false;"><em class="x-tab-left">',
                       '<span class="x-tab-strip-inner"><span class="x-tab-strip-text {iconCls}">{text}</span></span>',
                       '</em></a></li>'
                  );
    Tocco AG - technology meets spirit
    http://www.tocco.ch

  2. #2

  3. #3

    Default

    Yes, I think it's related to this one. But since it's closed, I think this one is still valid.
    Tocco AG - technology meets spirit
    http://www.tocco.ch

  4. #4
    Ext User
    Join Date
    Jul 2007
    Location
    Florida
    Posts
    9,996

    Default

    That thread is still OPEN. Closing this as DUP. You may want to subscribe to the other thread to monitor status.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •