Results 1 to 3 of 3

Thread: Layout change in nightly introduces DOM write during a read phase

    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-26680 in 6.5.3.
  1. #1
    Sencha Premium User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,257

    Default Layout change in nightly introduces DOM write during a read phase

    In the most recent 6.5.3 nightlies, there is a change in measureAutoDimensions which makes modifications to the DOM directly:

    Code:
    if (ownerContext.clearWidthFromDom) {
        owner.el.dom.style.width = '';
        ownerContext.clearWidthFromDom = false;
    }
    measureAutoDimensions is called from calculate, which is during a read phase. This could cause unnecessary reflows during layouts and negatively affect performance. From the docs:

    No writes should be made to the DOM in a read phase! Instead, the values should be written to the proper ContextItem for later write-back.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

  2. #2
    Sencha Premium User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,257

    Default

    Bump. This could have performance implications for layouts. This change should be more carefully considered.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

  3. #3
    Sencha - Sustaining Engineer tristan.lee's Avatar
    Join Date
    Mar 2015
    Location
    Central Ohio
    Posts
    1,579

    Default

    Thanks for the report! I have opened a bug in our bug tracker.

Similar Threads

  1. read and write from/to mysql database
    By thisisatin in forum Community Discussion
    Replies: 4
    Last Post: 5 Feb 2013, 3:02 AM
  2. Create Read/Write XMLStore in designer
    By GregoryC in forum Ext Designer: Help & Discussion
    Replies: 4
    Last Post: 10 Oct 2011, 12:33 AM
  3. read and write data from serial/usb
    By diegolovison in forum Community Discussion
    Replies: 4
    Last Post: 24 Feb 2011, 5:48 AM
  4. Write/Read in/from cookies in IE7
    By wertyk in forum Ext 2.x: Help & Discussion
    Replies: 0
    Last Post: 13 Jan 2009, 5:20 AM
  5. Replies: 6
    Last Post: 16 Apr 2008, 9:34 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •