Page 1 of 2 12 LastLast
Results 1 to 10 of 15

Thread: No errors thrown on route handler

    Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Sencha Premium User
    Join Date
    Sep 2013
    Posts
    6

    Default No errors thrown on route handler

    Ext version tested:
    Ext 6.5.1.345 Modern (Reproducible), Ext 6.5.0.775 Modern (Not Reproducible)

    Browser versions tested against:
    MacOS, Chrome, Safari, Firefox

    Fiddle:
    https://fiddle.sencha.com/#view/editor&fiddle/268g

    Steps To reproduce:
    1. Open provided fiddle example with Ext 6.5.1.345 Modern

    2. When click on "No Error" button. Route is changed and "onNoError" handler is executed.
    I expect to see "TypeError: Cannot read property 'substr' of undefined"
    3. Click on "Error" button error is thrown because there are try catch block in handler but it's not documented that route handlers needs try catch blocks

    Same example but with Ext 6.5.0.775 Modern is throwing error on both example. So it seems that it's bug in 6.5.1.
    Could you please have a look?



  2. #2

    Default

    I have the same issue as yours.
    I think it's because Ext.Promise inside the "execute" method of class "Ext.route.Route" doesn't use "catch" for error handling?

  3. #3

    Default

    This is a very serious problem

  4. #4
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,379

    Default

    You are correct that the promise is swallowing the error and this was fixed for 6.6 (the release we were working on before we moved on) where the error would be thrown by the router. So it'd be up to Idera to backport the fix if they would want to now since it seems 6.6 is a dead horse from what they've been communicating.
    Mitchell Simoens @LikelyMitch

    Check out my GitHub:
    https://github.com/mitchellsimoens

    Posts are my own, not any current, past or future employer's.

  5. #5

    Default

    I have found a workaround
    111.jpg

  6. #6
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,379

    Default

    Never edit the extjs source, create an override.
    Mitchell Simoens @LikelyMitch

    Check out my GitHub:
    https://github.com/mitchellsimoens

    Posts are my own, not any current, past or future employer's.

  7. #7
    Sencha Premium User
    Join Date
    Sep 2013
    Posts
    6

    Default

    You can also try catch the route handler:
    Code:
    crmRouteHandler: function (viewXtype, id) {
        try {
           // handler code
        }
        catch(err) {
            console.error(err);
        }
    }
    

  8. #8
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,379

    Default

    Or, create an override:

    Mitchell Simoens @LikelyMitch

    Check out my GitHub:
    https://github.com/mitchellsimoens

    Posts are my own, not any current, past or future employer's.

  9. #9
    Sencha Premium User
    Join Date
    Nov 2010
    Location
    Chicago
    Posts
    2,339

    Default

    Quote Originally Posted by mitchellsimoens View Post
    So it'd be up to Idera to backport the fix if they would want to now since it seems 6.6 is a dead horse from what they've been communicating.
    What do you mean by "dead horse"?

    IDERA communicated something opposite to what you are saying, i.e. they want to work on future Ext JS releases.

    Nobody knows if they will deliver or not, but the official statement (in the Sencha blog) is that the development work on future Ext JS releases will continue.

    "The path forward will build on the success of 6.5 and our goal will be to simplify future migrations. Version 7 and beyond will modernize in parallel with JS advances, but compatibility and ease of migration will be central to our release strategy."

  10. #10
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,379

    Default

    Because active dev before acquisition was 6.6 and now there is zero word on 6.6 so they changed things and haven't communicated it. Thought I even saw somewhere on forum or blog where someone asked about 6.6 and they said they are working on 6.5.3 with no word on 6.6 so my words based on what I see.

    Oh, it was your comment: https://www.sencha.com/blog/announci...-cmd-6-5-2-ga/
    Mitchell Simoens @LikelyMitch

    Check out my GitHub:
    https://github.com/mitchellsimoens

    Posts are my own, not any current, past or future employer's.

Page 1 of 2 12 LastLast

Similar Threads

  1. Project build breaks in SA 4.2.1 after upgrading to 6.5.x / Ext.app.route.Route
    By rmaliborski in forum Sencha Architect 4.x: Bugs
    Replies: 2
    Last Post: 21 Jul 2017, 2:25 AM
  2. [DUP] Router redirect with force option is calling 2 times the route handler
    By evandropoa in forum Ext JS 6.x Bugs
    Replies: 1
    Last Post: 14 Oct 2015, 2:25 PM
  3. [FIXED] Arguments are not defined for route before handler
    By seade in forum Sencha Architect 3.x: Bugs
    Replies: 1
    Last Post: 2 Sep 2014, 6:45 AM
  4. Replies: 5
    Last Post: 3 Jul 2012, 5:32 AM
  5. JS-Errors not shown in Firebug within an Ajax-Request-Handler
    By christ1an in forum Ext 1.x: Help & Discussion
    Replies: 2
    Last Post: 30 Oct 2007, 12:31 AM

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •