Component - unused local variable

[LesJ]

ext-6.2.1.121

Ext.define('Ext.Component', {
    ....
    onRemoved: function(destroying) {
        var me = this,
            refHolder, // <-- unused variable
            focusTarget;
        ...

[Kevin Jackson]

Can you flesh out what your question is?


Kevin Jackson
Sencha Support Team

[LesJ]

Can you flesh out what your question is?


Kevin Jackson
Sencha Support Team

This is a minor code issue. The refHolder local variable is not used, so it'd be better to remove it. Are we supposed to report issues of this kind? I'm trying to be helpful.

[Kevin Jackson]

Les

We always appreciate the input. I am just not sure what you are saying or where how you are seeing this. referenceHolder is a property but refHolder is only used in the mixin class that I see.


Kevin Jackson
Sencha Support Team

[LesJ]

I don't see that the refHolder variable is used in the onRemoved method in the Component class.
It's declared, but not used.

onRemoved: function(destroying) {
    var me = this,
        refHolder;


    if (Ext.GlobalEvents.hasListeners.removed) {
        me.fireHierarchyEvent('removed');
    }


    if (me.hasListeners.removed) {
        me.fireEvent('removed', me, me.ownerCt);
    }
    
    if (!destroying) {
        me.removeBindings();
    }


    me.onInheritedRemove(destroying);


    me.ownerCt = me.ownerLayout = null;
},

I pasted the entire Component.js file to jshint, I'm seeing this info.

Screen Shot 2017-02-06 at 3.56.15 PM.png

[Kevin Jackson]

Thanks so much. That was exactly what I was looking for. I'll let the Engineers know.


Kevin Jackson
Sencha Support Team

[Kevin Jackson]

Thanks for the report! I have opened a bug in our bug tracker.