Results 1 to 5 of 5

Thread: Collapsing TreePanel with WidgetColumn throws TypeError

    Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Ext JS Premium Member
    Join Date
    Jun 2009
    Posts
    63

    Default Collapsing TreePanel with WidgetColumn throws TypeError

    Fiddle:

    https://fiddle.sencha.com/#fiddle/rk6

    Ext version tested:

    • 5.1.1.451
    • 5.1.2.748
    • 5.1.3.228

    5.1.0.107 & 6.0.0.640 are both not affected.

    Browser versions tested against:
    • Chrome
    • Firefox
    • IE8
    • IE9

    Description:
    • Ext.grid.column.Widget#onItemRemove does not match itemremove Event fired in Ext.tree.View#onRemove

    Steps to reproduce the problem:
    • have tree panel with widget column
    • collapse a node

    The result that was expected:

    • works

    The result that occurs instead:
    • error thrown


    Fix:
    To be honest, I think the bug lies in Ext.tree.View#onRemove that fires the itemremove event with a different signature than defined in Ext.view.Abstract#itemremove. However the following code fixes the bug:

    ExtJs =< 5.1.2
    Code:
    Ext.define('Ext.fix.grid.column.Widget', {
        override: 'Ext.grid.column.Widget',
        
        privates: {
            onItemRemove: function(records, index, items) {
                var me = this;
                
                if (items instanceof Ext.tree.View) {
                    return;
                }
                
                return me.callParent(arguments);
            }
        }
    });
    ExtJs >= 5.1.3
    Code:
    Ext.define('Ext.fix.grid.column.Widget', {
        override: 'Ext.grid.column.Widget',
        
        privates: {
            onTreeViewItemRemove: function(record, index, view) {
                if (view.all) {
                    this.onItemRemove(record, index, view.all.item(index, true));
                }
            }
        }
    });

  2. #2
    Sencha - Sustaining Engineer tristan.lee's Avatar
    Join Date
    Mar 2015
    Location
    Central Ohio
    Posts
    1,579

    Default

    Thanks for reporting. It appears we already have a bug report for this that's marked to be fixed in our next 5.1.x release. This can be referenced by EXTJS-17744.

    Edit:

    The above bug reference is incorrect. It should be EXTJS-18794.
    Tristan Lee
    Sencha Inc - Sustaining Engineer


    Having an issue? Help us help you - be detailed; provide some code; demonstrate with a fiddle (fiddle.sencha.com)

    Embed your fiddle in your post: [FIDDLE]id[/FIDDLE]

  3. #3
    Ext JS Premium Member
    Join Date
    Jun 2009
    Posts
    63

    Default

    Interesting. May you post the link to the thread please? I searched the forum before posting the bug, but couldn't find anything about it. And I want to know what I missed / what key words my search was missing. Thanks!

  4. #4
    Sencha - Sustaining Engineer tristan.lee's Avatar
    Join Date
    Mar 2015
    Location
    Central Ohio
    Posts
    1,579

    Default

    I've updated my previous post. I was referencing a similar bug, but unrelated to the widget column issue you were experiencing.
    Tristan Lee
    Sencha Inc - Sustaining Engineer


    Having an issue? Help us help you - be detailed; provide some code; demonstrate with a fiddle (fiddle.sencha.com)

    Embed your fiddle in your post: [FIDDLE]id[/FIDDLE]

  5. #5
    Ext JS Premium Member
    Join Date
    Jun 2009
    Posts
    63

    Default

    Bug still exists in ExtJs 5.1.3. Is there any update on this?

Similar Threads

  1. [OPEN] TreePanel and widgetcolumn
    By ray_qwer in forum Ext 5: Bugs
    Replies: 14
    Last Post: 12 Jul 2017, 4:33 AM
  2. [DUP] Treepanel and widgetcolumn bug
    By rodionstl in forum Ext 5: Bugs
    Replies: 1
    Last Post: 26 Nov 2014, 7:41 AM
  3. Replies: 1
    Last Post: 9 Oct 2014, 10:08 PM
  4. [FIXED] Ext.SegmentedButton throws Uncaught TypeError
    By jens13583 in forum Sencha Touch 2.x: Bugs
    Replies: 5
    Last Post: 27 Feb 2012, 1:55 PM
  5. [FIXED] BUG: Slider.js throws TypeError exception
    By alex.k in forum Sencha Touch 2.x: Bugs
    Replies: 1
    Last Post: 7 Nov 2011, 9:09 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •