Page 6 of 6 FirstFirst ... 456
Results 51 to 58 of 58

Thread: Ext JS 5.1 - Documentation issues

    Thank you for reporting this bug. We will make it our priority to review this report.
  1. #51
    Sencha Premium User
    Join Date
    Nov 2013
    Location
    Piacenza, Italy
    Posts
    220

    Default Remove Ext.data.reader.Reader "exception" event

    The class Ext.data.reader.Reader (and derived classes) do not fire any more the "exception" event (while Ext JS 4 did), so it should be removed from documentation.

    Note: in Ext JS 4 the event was fired by getResponseData() in derived classes, for example by Ext.data.reader.Json.getResponseData().

  2. #52
    Sencha User
    Join Date
    Mar 2012
    Location
    Lawrence, KS
    Posts
    462

    Default

    SebTardif, LesJ, valio, MikeRH, zloi, The0s I have logged tickets for all of these issues. Thank you for your diligence! These reports help us make our documentation better, and we appreciate it.


    agarberi, that sounds like a framework bug. I'll look into creating a testcase to reproduce your findings.


    bambam, we have already fixed this. getData() does, in fact, return a collection

  3. #53
    Sencha Premium Member bambam's Avatar
    Join Date
    Dec 2012
    Location
    Moscow
    Posts
    81

    Question

    @greg.barry, but can you fix it not only in the extjs 6 docs, but for the extjs 5.1.0 too?
    image.jpg

  4. #54
    Sencha User
    Join Date
    Mar 2012
    Location
    Lawrence, KS
    Posts
    462

    Default

    Yes sir. We try to make adjustments to all of the branches with these sorts of fixes.

  5. #55
    Sencha Premium User
    Join Date
    Nov 2010
    Location
    Chicago
    Posts
    2,339

    Default

    Store.getAt returns null if not found, not undefined.
    Code:
    Ext.define('Ext.data.AbstractStore', {
        ...
        /**
         * Get the Record at the specified index.
         *
         * The index is effected by filtering.
         *
         * @param {Number} index The index of the Record to find.
         * @return {Ext.data.Model} The Record at the passed index. Returns undefined if not found.
         */
        getAt: function(index) {
            return this.getData().getAt(index) || null;
        },
        ...

  6. #56
    Sencha Premium User
    Join Date
    Nov 2010
    Location
    Chicago
    Posts
    2,339

    Default

    ext-5.1.1.389 and ext-6.0.0

    Typo: use re-entering instead.
    Code:
    Ext.define('Ext.data.BufferedStore', {
        ...
        reload: function(options) {
            ...
            // Prevent re-emtering the load process if we are already in a wait state for a batch of pages.
            if (me.loading) {
                return;
            }
            ...

  7. #57
    Sencha User
    Join Date
    Mar 2012
    Location
    Lawrence, KS
    Posts
    462

    Default

    Got them both. Thanks LesJ!

  8. #58
    Sencha Premium User
    Join Date
    Nov 2010
    Location
    Chicago
    Posts
    2,339

    Default

    This is a 6.0 documentation issue.

    See how I fixed the doc of the removeSeries method by indicating that the parameters may be an array as in the addSeries method. BTW I think these two new methods will be quite handy.
    Code:
    Ext.define('Ext.chart.AbstractChart', {
        ...
        /**
         * Adds a {@link Ext.chart.series.Series Series} to this chart.
         *
         * The Series (or array) passed will be added to the existing series. If an `id` is specified
         * in a new Series, any existing Series of that `id` will be updated.
         *
         * The chart will be redrawn in response to the change.
         *
         * @param {Object/Object[]/Ext.chart.series.Series/Ext.chart.series.Series[]} newSeries A config object
         * describing the Series to add, or an instantiated Series object. Or an array of these.
         */
        addSeries: function(newSeries) {
            ...
        },
    
    
        /**
         * Remove a {@link Ext.chart.series.Series Series} from this chart.
         * The Series (or array) passed will be removed from the existing series.
         *
         * The chart will be redrawn in response to the change.
         *
         * @param {Ext.chart.series.Series/String} series The Series or the `id` of the Series to remove. May be an array.
         * @param {Ext.chart.series.Series/Ext.chart.series.Series[]/String/String[]} series The Series or the `id` of the Series to remove.    
         */
        removeSeries: function(series) {
            ...

Page 6 of 6 FirstFirst ... 456

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •