ST 2.1.0 RC1 - Naming conflict in _color.scss

[Ballsacian1]

I was using the following scss in my application.scss file.

.x-field-select.x-item-disabled .x-component-outer {  @include filter(brightness(50%));
}

Since updating I now get the following response:

error application.scss (Line 15 of _color.scss: 50% is not a color for `red'

I've traced it down to line 14 of resources/themes/vendor/compass-recipes/stylesheets/recipes/_color.scss

@function brightness($color) {
    $r: red($color) / 255 * 100;
    $g: green($color) / 255 * 100;
    $b: blue($color) / 255 * 100;


    $brightness: (($r * 299) + ($g * 587) + ($b * 114)) / 1000;


    @return $brightness;
}

It seems to only be used by one another recipe s.scss and is causing a conflict with a CSS3 native property.

[Jamie Avins]

Thanks for the report! I have opened a bug in our bug tracker.

[Ballsacian1]

I've been trying to figure out a way, in case in the future other properties have this issue I can go about escaping them. Is there any way to escape something in sass so that it won't try and run a function that is named the same?

[rdougan]

The brightness function takes one parameter which is a color. You are passing it a percentage which is why compass spits an error. It returns the brightness of a specified color.

If you want to change the lightness of a color, you can use the compass function adjust-lightness. More information here: http://compass-style.org/reference/c...just-lightness

[Ballsacian1]

I'm actually trying to use the CSS3 Filter attribute. In standard CSS it would like like filter : brightness(59%); but this conflicts with functions that have been introduced in RC1. the sass functions should be changed to have a namespace. color_brightness for example.

Jordan

The brightness function takes one parameter which is a color. You are passing it a percentage which is why compass spits an error. It returns the brightness of a specified color.

If you want to change the lightness of a color, you can use the compass function adjust-lightness. More information here: http://compass-style.org/reference/c...just-lightness

[rdougan]

Sorry about that, I should have read your post properly.

I'll investigate and get back to you. Thanks.