[2.0][SOLVED] Window destroy error with tabs and buttons

**sven** · 15 Dec 2007, 10:44 AM

Hello,

if you have a window (panel) with a tabpanel in it with several tabs, than there is an error thown while destroying the window (panel).

Just close the window without switchting the tabs:
"this.el has no properties
var btn = this.el.child(this.buttonSelector);"

Code:

<html>
<head>
<link rel="stylesheet" type="text/css"  href="/css/ext-all.css" media="screen" id="theme"/>
<script src="/script/ext-base.js" type="text/javascript"></script>
<script src="/script/ext-all-debug.js" type="text/javascript"></script>
<script>
Ext.onReady(function(){
	Ext.QuickTips.init();
	new Ext.Window({
		height: 200,
		layout: "fit",
		width: 200,
		items: [{
			xtype: "tabpanel",
			activeTab: 0,
			items: [{
				title: "test",
				buttons: [{
					text: "test"
				}]
			},{
				title: "test2",
				buttons: [{
					text: "test2"
				}]
			}]
		}]
	}).show();
});
</script>
</head>
<body>
</body>
</html>

I think this happens because the buttons in the "not yet viewed tabs" arent rendered.

If you switched the tabs before (got rendered) everything works fine.

Tested in FF (latest) and IE7 on windows with ext2 final

Sven

**halkon_polako** · 15 Dec 2007, 11:44 AM

You have the solution in your words:"I think this happens because the buttons in the "not yet viewed tabs" arent rendered."

You are right, so to force the rendering in all tabs, you should use the deferredRender:false property on TabPanel:

Code:

....................
items: [{
    xtype: "tabpanel",
    activeTab: 0,
    deferredRender: false,
..................

regards...

**sven** · 15 Dec 2007, 12:54 PM

i know this one, but it isnt the best one

But it should be fixed inside of ext. Something that isnt rendered cant be destroyed. So destroy shouldnt be called on the buttons in these "not yet viewed/rendered" panels.

**halkon_polako** · 16 Dec 2007, 4:04 AM

I agree with you...

If the TabPanel behaviour is to can have a deferred rendering or not, then , when destroying the items, it should be taken in account: only destroy what can be destroyed, or with yourself words:Something that isn't rendered can't be destroyed

A patch can be:

Code:

Ext.override(Ext.Button,{
    beforeDestroy: function(){
        if (this.el){
            var btn = this.el.child(this.buttonSelector);
            if(btn){
                btn.removeAllListeners();
            }
        }
        if(this.menu){
            Ext.destroy(this.menu);
        }
    }
});

I also think this can be added/fixed inside Ext (of course, it should be validated by Ext Core Developers).
Regards...

**brian.moeskau** · 16 Dec 2007, 9:07 AM

This has already been reported and fixed in SVN.

Thread: [2.0][SOLVED] Window destroy error with tabs and buttons

Thread Tools

Search Thread

Display

[2.0][SOLVED] Window destroy error with tabs and buttons

Use deferredRender on TabPanel

Patch(override) Ext.Button::beforeDestroy

Posting Permissions

Stay Connected

Stay Connected

Sign up for Sencha News