Results 1 to 8 of 8

Thread: Performance on refreshing List view dramatically worse in RC than Beta 3

    Success! Looks like we've fixed this one. According to our records the fix was applied for a bug in our system in a recent build.
  1. #1

    Default Performance on refreshing List view dramatically worse in RC than Beta 3

    REQUIRED INFORMATION

    Ext version tested:

    • Sencha Touch 2.0 RC

    • Sencha Touch 2.0 Beta 3
    Browser versions tested against:
    • Chrome 17
    • Safari 5.1.3
    • Firefox 10.0.2
    Description:
    • List rendering is dramatically slower in RC over Beta 3. The RC List view becomes unusably slow to load if it contains a several hundred items (try 500, for instance).
    Steps to reproduce the problem:
    • Create a list view bound to a store
    • Render that list view
    The result that was expected:
    • It renders in a timely manner (near the speed of Beta 3)
    The result that occurs instead:
    • It is painfully slow, several times slower than Beta 3.
    Test Case:
    HELPFUL INFORMATION

    Note that in the github repo (and hosted example) I changed nothing about the List example except which framework version was being referenced.

    Load up the versions side by side and refresh a few times. You should see the difference. I can upload a version with more contacts if that helps but I wanted to show it with the baseline default number from the original example first.

    See this URL for live test case:
    http://sencha-rc-list-performance.heroku.com

    Debugging already done:

    • I did some profiling and it seemed that it is happening in the doItemDeselect being called from the refresh. I don't know much about it.
    Possible fix:
    • not provided
    Additional CSS used:
    • default css with each framework
    Operating System:
    • OS X Lion

  2. #2
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661

    Default

    Thank you for the testcase, we'll look into this right away.

    Sencha Inc

    Jamie Avins

    @jamieavins

  3. #3
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661

    Default

    Can you try this override, I'm sure it's the issue...:

    Code:
    Ext.define('Ext.dataview.Override', {
        override: 'Ext.DataView',
        deselectAll: function(supress) {
            var me = this,
                selections = me.getStore().getRange();
    
            me.deselect(selections, supress);
    
            me.selected.clear();
            me.setLastSelected(null);
            me.setLastFocused(null);
        }
    });

    Sencha Inc

    Jamie Avins

    @jamieavins

  4. #4

    Default

    Thank you for looking into this.

    I can confirm that the override restores performance to a level that feels on par with Beta 3. Let me know if there's anything else I can do to help.

    Is there anything I should be concerned about with using this override until the next release is out?

  5. #5

    Default

    Excellent. Thanks again.

  6. #6
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661

    Default

    No, this is quite safe. A really silly bug that has been in the deselectAll method for a longtime, it just wasn't used internally until RC.

    Sencha Inc

    Jamie Avins

    @jamieavins

  7. #7
    Sencha User
    Join Date
    Nov 2012
    Posts
    84

    Default

    Quote Originally Posted by Jamie Avins View Post
    Can you try this override, I'm sure it's the issue...:

    Code:
    Ext.define('Ext.dataview.Override', {
        override: 'Ext.DataView',
        deselectAll: function(supress) {
            var me = this,
                selections = me.getStore().getRange();
    
            me.deselect(selections, supress);
    
            me.selected.clear();
            me.setLastSelected(null);
            me.setLastFocused(null);
        }
    });
    Hi, I am new for sencha touch. My listing page is quite slow. Where should I put this code?

  8. #8
    Sencha Premium Member
    Join Date
    Feb 2011
    Posts
    75

    Default

    Where do you put this code?

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •