Results 1 to 10 of 10

Thread: [4.0.0] RowEditor ignores errorSummary

    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-4161 in TBD.
  1. #1
    Ext JS Premium Member Sébastien.Volle's Avatar
    Join Date
    Apr 2011
    Location
    Grenoble, France
    Posts
    70

    Default [4.0.0] RowEditor ignores errorSummary

    When using a grid with the Ext.grid.plugin.RowEditing plugin, the error summary tooltip is displayed at the start of edition even if 'errorSummary' property of the RowEditing instance is set to false.

    It's seems the problem lies in the underlying Ext.grid.RowEditor class and more specifically its 'loadRecord' method.

    The current code of the method is as follows:
    Code:
      loadRecord: function(record) {
          var me = this,
              form = me.getForm();
          form.loadRecord(record);
          if(form.isValid()) {
              me.hideToolTip();
          } else {
              me.showToolTip();
          }
            
          Ext.Array.forEach(me.query('>displayfield'), function(field) {
              me.renderColumnData(field, record);
          }, me);
      }
    I would recommend to apply the following change so that RowEditor complies with 'errorSummary' configuration:
    Code:
    loadRecord: function(record) {
          var me = this,
              form = me.getForm();
          form.loadRecord(record);
          if(form.isValid()) {
              me.hideToolTip();
          } else if(me.errorSummary) {               <==== Change here
              me.showToolTip();
          }
            
          Ext.Array.forEach(me.query('>displayfield'), function(field) {
              me.renderColumnData(field, record);
          }, me);
      }
    aka Seboss

  2. #2
    Sencha User atian25's Avatar
    Join Date
    Oct 2008
    Location
    china
    Posts
    114

    Default

    i got the same problem
    @from: china
    @web: http://atian25.iteye.com
    @extensions: (extjs 4.x)
    * Ext.ux.grid.plugin.RowEditing - add some usefull features (v1.4 updated 2011-09-11)
    * Ext.ux.button.AutoRefresher
    * Ext.ux.form.field.DateTime

  3. #3
    Sencha User
    Join Date
    Jul 2007
    Location
    London
    Posts
    25

    Default

    The beforeEdit method also needs updating to check the value of errorSummary:

    Code:
    beforeEdit: function() {
        var me = this;
    
        if (me.errorSummary && me.isVisible() && !me.autoCancel && me.isDirty()) { //<-- Add me.errorSummary
            me.showToolTip();
            return false;
        }
    },
    This bug remains unfixed in 4.0.3

  4. #4
    Sencha Premium User
    Join Date
    Feb 2011
    Location
    NJ
    Posts
    337

    Default

    This bug is still not fixed in 4.0.5.

  5. #5
    Ext JS Premium Member
    Join Date
    Jan 2008
    Location
    Germany, Berlin
    Posts
    135

    Default

    bump, in 4.0.6. still not fixed, got the same problem here. Is there an working override available?

  6. #6
    Sencha Premium User
    Join Date
    Feb 2011
    Location
    NJ
    Posts
    337

    Default

    The override in the original post works. I believe this has been submitted as a bug and should be fixed in 4.0.7.

  7. #7
    Ext JS Premium Member
    Join Date
    Jan 2008
    Location
    Germany, Berlin
    Posts
    135

    Default

    great, you're right the ovveride works in 4.0.6, looking forward to 4.0.7 ....

  8. #8

    Default

    This appears to still be a problem in 4.0.7.

  9. #9
    Sencha Premium User
    Join Date
    Feb 2011
    Location
    NJ
    Posts
    337

    Default

    Just checked the 4.1pr1 code and it has been fixed in there already.

  10. #10

    Default

    Excellent, then I guess I just have to wait a little bit longer...

Similar Threads

  1. Grid RowEditor; Communication between combo`s in a roweditor
    By Scorpie in forum Ext 3.x: Help & Discussion
    Replies: 1
    Last Post: 26 Sep 2010, 10:28 PM
  2. Replies: 6
    Last Post: 9 Sep 2010, 9:02 AM
  3. f is undefined in RowEditor.js line 169 when add row using RowEditor
    By evang in forum Ext 3.x: Help & Discussion
    Replies: 7
    Last Post: 4 Jun 2010, 3:22 PM
  4. IE ignores timezone in parseDate
    By kai5263499 in forum Ext 3.x: Help & Discussion
    Replies: 7
    Last Post: 5 Jun 2009, 5:36 AM
  5. v1.1.1 HtmlEditor ignores DOCTYPE IE6
    By MarkT in forum Ext 1.x: Help & Discussion
    Replies: 5
    Last Post: 4 Dec 2008, 1:30 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •