View Full Version : Looking for advice on implementation

16 Apr 2007, 10:22 PM
I am working on a online code review tool. The tool needs to display the changes in a side-by-side diff also reviewer's need to be able to double click on a line to popup a dialog for the reviewer to make a comment on the selected line. Right now I am loading the two versions of the files into two grids. I am finding that the larger the file content and the longer the grid my machine's performance goes way down.

I am starting to think that a grid is not the route that I want to go. I am looking for suggestions on how better to implement this. The requirements I have include:

* side-by-side diffs
* ability to double click on a line
* line highlighting for mouse over, lines with changes, and lines with comments
* lightweight enough to load a decent size file (15-20,000 lines should be more than enough)

Looking for suggestions

17 Apr 2007, 7:18 AM
A View might be better suited for this http://extjs.com/deploy/ext/docs/output/Ext.View.html

17 Apr 2007, 9:19 AM
Thanks Tim, I will give that a try tonight and see if I get better performance.

17 Apr 2007, 12:17 PM
Have you tried a paging grid?


17 Apr 2007, 12:25 PM
Nah, I want the entire page to be displayed and scrollable. Unless there is a way to cache sections of the page and as you scroll the lines show up or off of the page. The view grid really isn't working out that well either, but it was a huge improvement on performance. Almost need something between the Ext.View and Ext.grid.Grid. Something that will render the rows and columns like the grid along with supporting most of the events, but remain lightweight enough like the Ext.View.