Bug in VS Code Plugin since VS Code Update (>1.31)

[drifter2412]

Hi,

After installing the latest version of VS Code (v1.31.1) it seems to have triggered a bug in the plugin which stops the plugin from loading.


Activating extension 'Sencha.vscode-extjs' failed: Callback must be a function.
t._logMessageInConsole @ extensionService.ts:800
console.ts:134 [Extension Host] Activating extension 'Sencha.vscode-extjs' failed: Callback must be a function.
t.log @ console.ts:134
console.ts:134 [Extension Host] Activating extension `Sencha.vscode-extjs` failed: Callback must be a function


Stack is as follows:


[Extension Host] Here is the error stack: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
at maybeCallback (fs.js:157:9)
at Object.fs.writeFile (fs.js:1290:14)
at Object.<anonymous> ([...]\.vscode\extensions\sencha.vscode-extjs-1.0.1\out\src\Logger.js:28:8)
...


The problematic line seems to be:


fs.writeFile(path.join(Platform_1.default.settingsDir, 'vscode-extjs.log'), '');

Changing to:


fs.writeFile(path.join(Platform_1.default.settingsDir, 'vscode-extjs.log'), '', function(){});
or alternatively...

fs.writeFileSync(path.join(Platform_1.default.settingsDir, 'vscode-extjs.log'), '');

resolves the issue and the plugin loads again.

VS Code version info:

Version: 1.31.1 (user setup)
Commit: 1b8e8302e405050205e69b59abb3559592bb9e60
Date: 2019-02-12T02:20:54.427Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.16299

[Forum_Adm]

Hi there- thank you for bringing this to our attention. I have shared this with the support team and asked that they look into this at their earliest convenience. Your patience is greatly appreciated!

Kind Regards,

Michele

[seg]

I can confirm this, please fix this as soon as possible.

[JBAgilium]

Could you please give us a release date with the fix?

Thanks!

[Forum_Adm]

Hi there-

Has anyone opened a ticket through the support portal? We do suggest using the support portal when you need assistance with a capability of a Sencha product, you have identified a situation where a products behavior is inconsistent with the product documentation and might indicate a software bug, or when the communication between you and Sencha needs to be private.

Thank you,

Michele

[wo_ksanders]

I can confirm that the change in the line of code mentioned by drifter2412 fixes the issues with the extension not working that I was seeing locally.

[Dengqiao Huang]

Thank you very much, the Plugin works.

[Dumbledore]

It's a shame that users have to fix bugs themselves, even though they pay for the program and support ... :s

The plugin is unchanged since May 25, 2018

That's really disappointing

[seg]

It's even much older, hasn't been updated since January 11, 2017!


It's a shame that users have to fix bugs themselves, even though they pay for the program and support ... :s

The plugin is unchanged since May 25, 2018

That's really disappointing

[lovelyhibabe]

Edit this file `C:\Users\username\.vscode\extensions\sencha.vscode-extjs-1.0.1\out\src\Logger.js`
57937
or
57938

[JBAgilium]

I'm agree!


It's a shame that users have to fix bugs themselves, even though they pay for the program and support ... :s

The plugin is unchanged since May 25, 2018

That's really disappointing

Thank you very much to drifter2412 (https://www.sencha.com/forum/member.php?712859-drifter2412) & lovelyhibabe (https://www.sencha.com/forum/member.php?576518-lovelyhibabe) for the hints.

[ground_call]

Thank you for the fix. It worked on VS Code 1.34.0
Shame on Sencha.

[lsie]

Thanks drifter2412 (https://www.sencha.com/forum/member.php?712859-drifter2412), still working on 1.35.1

[mhancock1]

Thanks drifter2412, I can confirm that it is working on 1.36.1.