PDA

View Full Version : [OPEN] Minor - Examples 6.5.x : Panel example should include require for Collapser



thesandbender
4 Aug 2017, 4:20 PM
I'd suggest updating the Panel example to explicitly call Ext.require('Ext.panel.Collapser')

http://examples.sencha.com/ExtReact/6.5.0/kitchensink/#/components/panel

It took a moment or two of head scratching to figure out why the collapser wasn't showing up when I copied the example component code.

Mark.Brocato
8 Aug 2017, 6:03 AM
Thanks for the report! I have opened a bug in our bug tracker.

LesJ
9 Aug 2017, 10:57 AM
Thanks for the report! I have opened a bug in our bug tracker.

Is this an Ext JS bug (https://www.sencha.com/forum/showthread.php?363100-Extjs-6-5-0-modern-gt-Collapse-icon-panel-in-production), not ExtReact? See bereachad's (https://www.sencha.com/forum/showthread.php?362630-Collapse-icon-panel-in-production)answer.

thesandbender
9 Aug 2017, 1:13 PM
Is this an Ext JS bug (https://www.sencha.com/forum/showthread.php?363100-Extjs-6-5-0-modern-gt-Collapse-icon-panel-in-production), not ExtReact? See bereachad's (https://www.sencha.com/forum/showthread.php?362630-Collapse-icon-panel-in-production)answer.

It's not a bug in the code for either, the ExtReact example code for collapsible panels doesn't include the require for the panel collapser. The example works because it including an ExtReact build that does have the plugin included, but someone just learning react is probably not going to realize they need to add the require (which is probably what let to the bug report you linked to ... bereachad's answer was to require the plugin).