PDA

View Full Version : 6.2.1 classic: Ext.window.Toast change log not reflected in docs/sources



fabricio.object
28 Dec 2016, 9:34 PM
Hello. There must be something wrong with me, but I see this change on Ext.window.Toast in 6.2.0 to 6.2.1 change log:

- Ext.window.Toast: removed autoLoadDelay config option (http://docs.sencha.com/extjs/6.2.1/guides/whats_new/api_diffs/621_classic_diff.html#whats_new-_-api_diffs-_-621_classic_diff_-_ext_window_toast)

But I still see the config option both in code and documentation:
- Ext.window.Toast.autoLoadDelay - ExtJS 6.2.1 classic API docs (http://docs.sencha.com/extjs/6.2.1/classic/Ext.window.Toast.html#cfg-autoCloseDelay)

I also see Ext.window.Toast.afterPositioned() uses the autoCloseDelay. So maybe this change log has been added by mistake, similarly to the other report here (https://www.sencha.com/forum/showthread.php?334315-6-2-1-classic-Ext-dd-DragTracker-beforedragstart-gt-beforestart-rename-issue)?

Kevin Jackson
5 Jan 2017, 2:58 PM
Thanks for the report! I have opened a bug in our bug tracker.

greg.barry
9 Jan 2017, 3:49 PM
Fabrico,

Thanks for taking a look at the changelog and evaluate the SDK. Actually, there were duplicates of the config and one of the duplicates was removed. So the changelog is accurate, but it could certainly be seen as misleading without further context.

Thanks!
Greg

fabricio.object
9 Jan 2017, 9:17 PM
Oh yeah, got it, I didn't really see where the duplicate were removed in the diff but I didn't dig down to this either. Something like removed duplicated autoLoadDelay config option would certainly be clear enough!

Thanks for reviewing this, was lost on the reason that entry was there. :) The changelog really helps! Something I also missed in changelog is whether the changed thing is public or private.

Sometimes there's a change in private stuff. Does not go to changelog (what is reasonable enough). Sometimes private things become public or the other way around -- and they get to changelog, what it good too. But sometimes a private entity (method, config option, property) changes and go to changelog. :) Anyway, that's too small an issue, I will not open a whole bug report for that.